rgonslayer / pe

0 stars 0 forks source link

When adding long names, it becomes cut off. #7

Open rgonslayer opened 2 years ago

rgonslayer commented 2 years ago

When adding a name that is too long, it is cut off and users are unable to see the full name.

The name could have been wrapped or the length limited to ensure such behaviour does not occur.

Command: add n/John Doe Doe Doe Doe Doe Doe Doe Doe Doe Doe Doe Doe Doe Doe Doe p/98765432 e/johnd@example.com s/NUS Global Merit Scholarship as/pending m/Medicine m/Computer Science

Screenshot 2022-11-11 at 16.55.04.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Long scholarship names are not fully visible

To reproduce

Steps to reproduce:

  1. Create applicant add n/Superman p/98765432 e/johnd@example.com s/CN Yang NUS Overseas College NOC Philip Yeo Scholarship Grant cum laude as/pending m/science m/philo

Expected

I should be able to see the full name of scholarship

Actual

Cannot be seen. no ... either

Screenshots

image.png

OS

Windows 10


[original: nus-cs2103-AY2223S1/pe-interim#4915] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Justification for downgrading from severity.Low to severity.VeryLow:

Given that the above input value is unusually long, and that it is pretty rare that an administrative staff will key in the entire scholarship name instead of abbreviation of such names. Additionally, our application is able to display the entire scholarships for all scholarship names on a standard 1920x1080 screen for NUS related scholarships since our application is targetted at NUS administrative staff.

Hence, we considered it as an issue with severity of VeryLow, that affects the visibility of such inputs.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The issue this is marked as a duplicate of refers to scholarships, where the team defended by saying that NUS staff are likely to use abbreviations. However, the issue raised by myself is regarding names.

The longest name is 747 characters long. While extreme, it should be considered.

Screenshot 2022-11-17 at 16.58.05.png


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: This is not purely a cosmetic issue and can cause hindrance to users when combined with having to unpin using names.