search

rh-hideout / pokeemerald-expansion

Feature branche for the pokeemerald decompilation. See the wiki for more info.
345 stars 1.03k forks source link

Dynamax Mons gain HP incorrectly when leveling up #4538

Open WillKolada opened 4 months ago

WillKolada commented 4 months ago

Description

In the following example, my Sneasler was Dynamaxed for three turns, during it which it took no damage. When Dynamax reverted, it lost 1 HP. I presume this is a rounding error.

image

EDIT: I reproduced the issue, except this time Sneasler lost 3 HP at the end of a round while still Dynamaxed.

image

EDIT 2: I realized the issue is caused by leveling up while Dynamaxed. The Max HP increases, but not all of the effective HP does to match it, just a portion, which I believe is the incorrect behavior.

EDIT 3: I've also now experienced twice where my Pokemon had taken damage while Dynamaxed, then leveled up and was essentially fully healed. Bizarrely, in one of these instances, it even took a hit and received no damage.

Version

upcoming (Edge)

Upcoming/master Version

0aad2a9ba7b358f559c50ecc07a8752400f1d64f

Discord contact info

Special K#8400

hedara90 commented 2 months ago

I can confirm that something is not correct regarding HP. The Bulbasaur leveled up from 7 to 15 and ended up with 2444/82 HP pokeemerald-1