rhevm-qe-automation / ovirt-ansible

Ansible playbooks for ovirt management
GNU General Public License v3.0
26 stars 28 forks source link

ovirt-collect-logs: collect /var/log/ovirt-imageio-daemon/* #168

Closed tareqalayan closed 6 years ago

mykaul commented 6 years ago

This role should be removed asap and be replaced with a call to ovirt-log-collector. You are needlessly replicating functionality

KKoukiou commented 6 years ago

@lukas-bednar @nellyc @tareqalayan @StLuke Can somebody elaborate why we developed this role and we didn't use the ovirt-log-collector as @mykaul suggests?

I heard that we don't want collection from database, but the ovirt-log-collector allows that with option --no-postgresql. Any other reason? If not I 'll move to removal of this role and usage of the official tool.

StLuke commented 6 years ago

@KKoukiou I agree with @mykaul tp some extent... we should use log-extractor in the automation as we do not have to maintain it and it has all the functionality... However, I don't see a reason to remove this. We can leave it in this open source project as it's using different technology than log-extractor.

tareqalayan commented 6 years ago

we will remove it, currently log collector also collects db and requires many storage and time and sometimes the engine is down so the log collector won't work and we still need the logs. and we don't run where the log collector package is installed.

mykaul commented 6 years ago

If the Engine is down, you can specify the hosts manually on the command line. It just means you are less testing the ovirt-log-collector.