search

rhevm-qe-automation / ovirt-ansible

Ansible playbooks for ovirt management
GNU General Public License v3.0
26 stars 28 forks source link

upgrade answer: add fixDbConfiguration answer #99

Closed petr-balogh closed 7 years ago

petr-balogh commented 7 years ago

Change-Id: I50b8f57c78aebc4a43df8c28d0d492cf3b92b201

petr-balogh commented 7 years ago

Verified locally with this answer added to generated answerfile

mykaul commented 7 years ago

I think you should consider adding '--accept-defaults' to engine-setup command execution.

StLuke commented 7 years ago

This was considered before, however we believe that we should be aware of any new config values added to setup and accommodate our playbooks and in the end tests to them. These values in answer files are not documented, thus this forces us to review every new config values added for deployment by playbook. Most testing is done via these playbooks and we really don't wanna get some value unnoticed that can potentially break it as we are not going with default values in all answers.