rhlsthrm / typescript-solidity-dev-starter-kit

Starter kit for smart contract development using Typescript
410 stars 127 forks source link

Bug in tests #1

Closed sobolev-igor closed 5 years ago

sobolev-igor commented 5 years ago

Hi! Thanks for the repo!

I've tried to run tests, but the second one fails here, as count variable of Counter contract is set to 0 inside the beforeEach() call. Therefore, countDown() function call reverts!

You should add countUp() function call before counting down :)

rhlsthrm commented 5 years ago

Hey @sobolev-igor! The test actually errors on purpose to show the power of the Solidity stack traces that Buidler enables! I should make a note of this. Thanks for the feedback!

rhlsthrm commented 5 years ago

https://github.com/rhlsthrm/typescript-solidity-dev-starter-kit/blob/master/README.md#run-contract-tests

I've updated the README to reflect!

sobolev-igor commented 5 years ago

Oh, I got it!