search

rhtconsulting / rhc-ose

OpenShift Automation and Utilities by Red Hat Consulting
42 stars 34 forks source link

Containerizing Redis Cluster #209

Closed shah-zobair closed 8 years ago

shah-zobair commented 8 years ago

What does this PR do?

Containerizing Redis Cluster

How should this be manually tested?

See the readme.md

Is there a relevant Issue open for this?

It's a demo

Who would you like to review this?

/cc @etsauer @shraderdm

etsauer commented 8 years ago

@shah-zobair just one comment above, otherwise looks good.

shah-zobair commented 8 years ago

@etsauer : Renamed the "Implementation Guide". Actually, I have included everything in Readme and I think the Implementation Guide is not necessary anymore.

Is there any better way to parameterize the Registry URL inside the yaml files?

etsauer commented 8 years ago

The best way is to pull the image URL out of the deployment Configs and into a common ImageStream, then have all the yaml files reference that image stream. At least then it's hard coded in fewer places. Then the instructions to configure it for a particular cluster can be simpler.