Closed shah-zobair closed 8 years ago
@shah-zobair just one comment above, otherwise looks good.
@etsauer : Renamed the "Implementation Guide". Actually, I have included everything in Readme and I think the Implementation Guide is not necessary anymore.
Is there any better way to parameterize the Registry URL inside the yaml files?
The best way is to pull the image URL out of the deployment Configs and into a common ImageStream, then have all the yaml files reference that image stream. At least then it's hard coded in fewer places. Then the instructions to configure it for a particular cluster can be simpler.
What does this PR do?
Containerizing Redis Cluster
How should this be manually tested?
See the readme.md
Is there a relevant Issue open for this?
It's a demo
Who would you like to review this?
/cc @etsauer @shraderdm