NyaoVim is unable to run

rhysd / NyaoVim

Web-enhanced Extensible Neovim Frontend

Other

2.22k stars 57 forks source link

NyaoVim is unable to run #118

Closed haifengkao closed 7 years ago

haifengkao commented 7 years ago

NyaoVim is unable to run with errors

main/browser-config.ts(9,30): error TS2694: Namespace 'Electron' has no exported member 'BrowserWindowOptions'.

Expected Behavior

should start ok

Actual Behavior

unable to start

Steps to Reproduce (including precondition)

git clone https://github.com/rhysd/NyaoVim.git
cd NyaoVim
npm install
npm start

Your Environment

OS: OSX
NyaoVim version: 0.0.22
nvim version: not installed yet

rhysd commented 7 years ago

I think Electron 1.6.10 causes this problem. It contains official type definitions and they are different from ines in DefinitelyTyped. We need to fix version to 1.6.9 for now.

rhysd commented 7 years ago

I addressed this in 748c2aa. Please git pull in cloned NyaoVim repo and npm install again.

haifengkao commented 7 years ago

Your fix doesn't work. I have to set Electron to 1.6.8 and fix every module versions in package.json to make npm start run without any errors. I think it is better to add package-lock.json to avoid any similar issues in the future. Please refer to https://github.com/rhysd/NyaoVim/pull/119

rhysd commented 7 years ago

I fixed compilation error problems due to new official type definitions in 59e2199f14e8350a42bf3761e7c4a7630c9321e0 and now compilable with Electron 1.7. I'll close this.