search

rhysd / electron-about-window

'About This App' mini-window for Electron apps
https://www.npmjs.com/package/about-window
MIT License
409 stars 46 forks source link

Version should be overridable by custom version string #52

Closed peanutbother closed 3 years ago

peanutbother commented 4 years ago

see https://github.com/rhysd/electron-about-window/issues/51

rhysd commented 4 years ago

Please avoid formatting.

rhysd commented 4 years ago

@peanutbother BTW why author of the commits is different from you? They are committed by @eldnub

peanutbother commented 4 years ago

@peanutbother BTW why author of the commits is different from you? They are committed by @eldnub

this is because I have different workplaces with different gpg keys because I maintain private git servers with gpg signing, so I sometimes commit as my ghost account

Please avoid formatting.

I accidentally formatted because I use prettier in vscode which does this automatically. I will rebase ASAP

rhysd commented 4 years ago

this is because I have different workplaces with different gpg keys because I maintain private git servers with gpg signing, so I sometimes commit as my ghost account

OK. I wanted to confirm other's commits are not in this branch for sure.

I accidentally formatted because I use prettier in vscode which does this automatically. I will rebase ASAP

Thanks. Just merging current master into this branch and running npm run prettier would be fine.

rhysd commented 3 years ago

Closing in favor of #53