search

rhysd / electron-about-window

'About This App' mini-window for Electron apps
https://www.npmjs.com/package/about-window
MIT License
409 stars 46 forks source link

About window on windows seems pretty limited #59

Open yafp opened 4 years ago

yafp commented 4 years ago

... or i am messing it up.

I am using about-window 1.13.4 and the about window on linux is as i am expecting it. See screenshot:

media_dupes_on_linux2020-06-23 21-16-08

The same build on windows shows the following about window:

84192162-e2340680-aa99-11ea-953c-e8c46ab95f04

Any idea why:

Mavahu commented 4 years ago

Please share your source code. You probably made a minor mistake, since it's working fine for me on windows.

yafp commented 3 years ago

@Mavahu

The related project is here: https://github.com/yafp/media-dupes The main js file here: https://github.com/yafp/media-dupes/blob/master/main.js

billiegoose commented 3 years ago

I'm seeing the same issue.

const openAboutWindow = require('about-window').default;

// later on
        openAboutWindow({
          icon_path: path.join(__dirname, '..', 'icon.png'),
          copyright: 'Copyright (c) 2020 Stoplight, Inc',
        });

Linux:

image

Windows: image

billiegoose commented 3 years ago

Hang on, I'm gonna test to see if it's a / vs \ thing.

Update: nope, that's not it. Not sure what problem is.

billiegoose commented 3 years ago

Alright, figured it out. It is an error in usage: when declaring the menu item for the About dialog, be sure to not specify role: 'about'.

image

It appears in previous versions of Electron, the about role was undefined in Windows and now it is, or the click handler overrode the role or something. I guess Linux has never had it defined so that the presence of the role property there has never caused an issue.

Anyway. Now I get a lovely dialog on Windows. image