search

rhysd / neovim-component

<neovim-editor> WebComponent to embed Neovim to your app with great ease
https://github.com/rhysd/NyaoVim
MIT License
193 stars 18 forks source link

Enable building even when there are errors #38

Closed ghost closed 7 years ago

ghost commented 7 years ago

Sometimes (e.g. due to typings updates), there will appear errors in the source which prevents the package to be built, even though it works. To remedy this, noEmitOnErrors has been set to false and the build script has been updated to package even when there were TypeScript errors.

rhysd commented 7 years ago

You should not ignore TypeScript errors.

rhysd commented 7 years ago

What is actual error? I may be able to fix.

ghost commented 7 years ago

Some errors are just hints, and can safely be ignored. But I admit, I was a bit too lazy to go through them. It seems like the problem is inside a typings file:


shadowRoot?: webcomponents.ShadowRootPolyfill;
~~~~~~~~~~

typings/globals/webcomponents.js/index.d.ts(48,5): error TS2403: Subsequent variable declarations must have the same type.  Variable 'shadowRoot' must be of type 'ShadowRoot', but here has type 'ShadowRootPolyfill'.

shadowRoot?: webcomponents.ShadowRootPolyfill;
~~~~~~~~~~

typings/globals/webcomponents.js/index.d.ts(48,5): error TS2687: All declarations of 'shadowRoot' must have identical modifiers.
rhysd commented 7 years ago

Thank you for the log. I'll check the type definition. Type definition may be updated for Polymer 2.

ghost commented 7 years ago

No problem :)