search

rhysd / neovim-component

<neovim-editor> WebComponent to embed Neovim to your app with great ease
https://github.com/rhysd/NyaoVim
MIT License
193 stars 18 forks source link

Fix cursor shape (e.g.: cmdline_insert) #42

Closed chitoku-k closed 7 years ago

chitoku-k commented 7 years ago

What was a problem?

The cursor shape was weird when the class NeovimCursor processes cmdline_insert action. This is emitted when moving the cursor in command line window at the bottom.

How this PR fixes the problem?

All the actions whose name ends with insert have currently vertical cursor that can be confirmed emitted at the first action. There are other cursor shapes in Neovim such as when replacing text, however, this PR does not yet deal with them.

Check lists

rhysd commented 7 years ago

I think there were some update to protocol between neovim process and frontend. There was no cmdline_insert action when I implemented this package. I need to look into the latest. Anyway, this change looks good. Thank you.