search

riak-ripple / ripple

A rich Ruby modeling layer for Riak, Basho's distributed database
Other
618 stars 152 forks source link

Avoid overwriting rails db:* tasks #317

Open StabbyCutyou opened 11 years ago

StabbyCutyou commented 11 years ago

This is effectively a clone of https://github.com/basho/ripple/pull/313 , but specifically for the v1.0.0.beta2 tag

We're currently using this tag, but the rake task integration is a major problem that was recently uncovered.

The fix presented in the above PR is exactly what we need, but it has not been reflected anywhere other than master.

I have a branch created in my fork that handles this, but I'm not really sure how best to request integrating it, as tags are usually immutable, and I cannot perform a PR into one.

Perhaps a beta3 tag with this change?

Please advise

https://github.com/StabbyCutyou/ripple/tree/v1.0.0.beta3

thunder- commented 11 years ago

Yes that would be nice if there could be a new release tag added to rubygems, also because it would solve https://github.com/basho/ripple/pull/308 which we're now working around for ..

Thanks :)

StabbyCutyou commented 11 years ago

Actually, I would prefer if this only changed the rake tasks issue - We do want to move to an upgraded version of the riak client, but as we're using that in some legacy areas in a few specific ways, we don't want to make that change just yet.

By keeping this tag at it's current requirement level, you're still free to require a higher level version of the client yourself directly, as is my understanding of how gems work. By changing it, you'd be forcing an upgrade.

StabbyCutyou commented 11 years ago

@seancribbs any chance I could get some feedback on your willingness to put out a new tag with the rake task fix, so that we don't need to rely on master?

I can also just use my own fork, but I figure this is the kind of thing others may want, while wanting to standardize on a tag, instead of master (which could change)