search

riannucci / rietveldv2

rietveldv2
Apache License 2.0
1 stars 1 forks source link

Add Access-Control-Allow-Origin header #27

Open andialbrecht opened 10 years ago

andialbrecht commented 10 years ago

The API should set Access-Control-Allow-Origin: * to make the API accessible for JavaScript clients running on different servers.

I'm not sure about the right place for adding this header to the response. Either in some middleware or in app.yaml (https://developers.google.com/appengine/docs/python/config/appconfig#http_headers).

Instance maintainers should be able to configure this setting (either in app.yaml or in a custom settings file/module).

andialbrecht commented 10 years ago

Just noticed, that it won't work in app.yaml:

"Unexpected attribute "http_headers" for mapping type script."

riannucci commented 10 years ago

Probably want to do it in the rest_handler

On Tuesday, February 4, 2014 6:34:49 AM, Andi Albrecht < notifications@github.com> wrote:

Just noticed, that it won't work in app.yaml:

"Unexpected attribute "http_headers" for mapping type script."

Reply to this email directly or view it on GitHubhttps://github.com/riannucci/rietveldv2/issues/27#issuecomment-34064277 .