rib / jsonwebtokens

A rust implementation of Json Web Tokens
MIT License
43 stars 7 forks source link

[feat] EdDSA algorithm #35

Open beanow-at-crabnebula opened 1 year ago

beanow-at-crabnebula commented 1 year ago

Has some great properties, like being deterministic, why you might choose it over the ECDSA family.

https://www.rfc-editor.org/rfc/rfc8037

beanow-at-crabnebula commented 1 year ago

I should add, would you accept PRs on this feature? And are there any gotchas in contributing you can think of? :]

rib commented 1 year ago

Thanks. Yeah, I'd be happy to review a PR for adding EdDSA support. I'm not familiar with EdDSA atm but wouldn't expect any major gotchas, assuming it's supported in ring.

beanow-at-crabnebula commented 1 year ago

Ring does support Ed25519 / X25519, but not Ed448 / X448.

The way I'm reading the RFC8037, it doesn't seem required to implement both. It seems to stress interoperability first.

beanow-at-crabnebula commented 1 year ago

Sorry I haven't picked this up. I had conflated this library and https://github.com/Keats/jsonwebtoken Currently evaluating their crate. Since they also use ring, there's support only for Ed25519 but not Ed448.

rib commented 1 year ago

:) no worries.