search

ribs498 / Scorched-Guns-1.20.1

Scorched Gunssss
Other
3 stars 1 forks source link

[Suggestion] Add config option for what helmets make you immune to gas. #19

Open SPYROHAWK opened 2 weeks ago

SPYROHAWK commented 2 weeks ago

Pretty straightforward for cross-mod compatability.

In the recent updates, Scorched Guns added gas grenades, as well as vents and other sources of gas. Two respirator helmets were also added, which make you immune to the gas. However, for pack creators, more options would be nice.

The Plague Helmet and Diving Helmet from Protection Pixel logically feel like they should make you gas immune. Same with all of the gas masks from Marbeled’s Arsenal. But there’s so many more. Gas Mask from Steampowered. Space suits from Ad Astra? Hazmat suit from Alex’s Caves?

Rather than adding compatability for every mod that could possibly work as a gas mask, I figured it wouldn’t be too hard to just add a line to the config file where pack creators can list helmets that work as gas masks.

ribs498 commented 2 weeks ago

Absolutely makes sense. Will do

SPYROHAWK commented 1 week ago

Just wanted to follow up on this. Nothing wrong with the mod, this is purely me not knowing things, and this seems like the most relevant place to ask.

I saw in the most recent update, it contains this line: "Adjusted sulfur gas to take into account the "gas_mask" tag, with a few mods gas masks added by default"

Fantastic! Two questions though. I always forget how doing stuff with tags works.

1) How do you view what items are in a tag? 2) How do you add items to a tag?

Any help would be appreciated! I've been trying to search online but I can't quite figure it out.

ribs498 commented 1 week ago

So if you download the data pack, linked on the mod pages, and extract it and go into data/scguns/tags/items then find gas_mask then you could add whatever helmet you'd like