App ready for review

[ricardobed]

My app is ready, can you please review it?

cc @nesquena @timothy1ee

Thanks, Ricardo

[timothy1ee]

Very good, nice work. Nice semantic naming of variables and methods in the iOS style. Some feedback

• From a UI perspective, the convert button should be visible when the keyboard is visible. Otherwise, the user must tap Done before tapping Convert.
• It is more common to use private properties instead of private instance variables. For example,

@property (nonatomic, assign) float celsius;
@property (nonatomic, assign) float fahrenheit;

• Why does - (BOOL)doneButton return a bool? Also, the name implies that it returns a Done button. Perhaps it should be - (void)onDoneButton, and it should be private, i.e., declared in the class extension.

//
//  TempViewController.m
//  TempConverter
//
//  Created by Ricardo Bedoya on 7/24/13.
//  Copyright (c) 2013 Ricardo Bedoya. All rights reserved.
//

#import "TempViewController.h"

@interface TempViewController ()

- (void)onDoneButton;

@property (nonatomic, assign) float celsius;
@property (nonatomic, assign) float fahrenheit;

@end

[ricardobed]

• The convert button is not visible because I wanted the user to first click on Done when they finished entering the temperature values and then tap on convert to get the results.
• The reason why doneButton was a BOOL was because I tried to do other stuff that later I removed and forgot to change it back to (void).
• As for the properties instead of private instance variables, I'll keep that in mind.

Thanks!