ricardofbarros / linter-js-standard

Atom linter plugin for JavaScript, using JavaScript Standard Style
https://atom.io/packages/linter-js-standard
MIT License
99 stars 50 forks source link

"Something went wrong internally, reopen and no worries" #179

Closed corysimmons closed 7 years ago

corysimmons commented 7 years ago

https://github.com/atom/atom/issues/14248

Happens really frequently for no discernible reason.

damon-kreft commented 7 years ago

Yeah same here. Consistently the the very first time I open Atom and my first JS file, whether standard is in devDependencies or not...

screen shot 2017-04-19 at 02 52 25

Here are my Atom settings/packages: https://gist.github.com/damon-kreft/9801de58dce368df4f06b917f317559a

dcalhoun commented 7 years ago

I can confirm this warning displays when opening the first JavaScript file after creating a new Atom window. It happens every time consistently. After the first JavaScript file is open, the warning does not appear again until I create a new Atom window (i.e. the warning does not display for the 2nd, 3rd, 4th, etc JavaScript file).

Environment

mattfysh commented 7 years ago

I don't know enough about atom internals but it looks like this.cache.get('text-editor', ... inside of linter-js-standard.js is being trigger before the call to this.cache.set... in init.js

dcalhoun commented 7 years ago

This is a duplicate of #126 and should likely be closed.

whaaaley commented 7 years ago

@dcalhoun i think this issue differs because:

pablomayobre commented 7 years ago

I had this same issue, as @whaaaley explained, it started to happen after my configuration was reset (for some other problem I'm guessing).

I cannot reproduce this consistently though

revelt commented 7 years ago

Confirmed, it's happening exactly as @whaaaley described. First open of first JS file. Subsequent opens won't trigger the error. I can recreate it, just close the window, open some project, click on the tree view on any JS file, error will appear.

It will appear again and again if you won't double-click-open one JS file and close it. After closing, it does not appear on that window any more.

revelt commented 7 years ago

Switching to an alternative Standard linter, linter-js-standard-engine solved this for me.

whaaaley commented 7 years ago

@revelt Looks nice, however it looks like everything is an error rather than having some warnings, but that's much more tolerable than a message window. I'll be using this from now on too.

whaaaley commented 7 years ago

@revelt Looks like that project doesn't have html support or support for a global install or a default engine... all of those things are kind of a bummer for me. I might go digging later and try to fix this.

whaaaley commented 7 years ago

Looks like the PR by @educcjr fixes this! I just cloned and tested it out.

sonicdoe commented 7 years ago

This will be fixed in an upcoming patch version.

sonicdoe commented 7 years ago

Released in v3.9.2 🎉

revelt commented 7 years ago

I can confirm 3.9.2 works perfectly. Thanks everybody!