search

ricardofbarros / linter-js-standard

Atom linter plugin for JavaScript, using JavaScript Standard Style
https://atom.io/packages/linter-js-standard
MIT License
99 stars 50 forks source link

Linter doesn't seem to be receiving options from package.json #206

Closed saadq closed 7 years ago

saadq commented 7 years ago

For example, let's say I have this in my package.json file:

{
  "standard": {
    "ignore": ["src/tests"]
  }
}

If I run standard in the command line, I don't get any errors. However, when I open the file in my editor, I still have the errors displayed:

screen shot 2017-09-12 at 4 51 48 pm

I'm on Atom v1.20.0 and using linter-js-standard v4.0.1. Let me know if I can provide any other info.

sonicdoe commented 7 years ago

Thank you, I was able to reproduce this.

The issue is that minimatch doesn’t match directories (like e.g. .gitignore does). Coincidentally, ESLint had the same issue three years ago. I’ll probably fix this using ignore in the next patch version.

sonicdoe commented 7 years ago

Should be fixed in v4.0.2.