search

ricardograca / gedit-themes

Color themes for Gnome's Gedit text editor
21 stars 7 forks source link

Additional Install Script #1

Closed HandyAndyShortStack closed 11 years ago

HandyAndyShortStack commented 11 years ago

the install script provided gave me the following error:

cp: target `/home/andy/.local/share/gedit/styles/.' is not a directory

It seems that gedit sits in my file system differently than in yours. I wrote an install script that works for my OS and gedit versions: ubuntu 12.10 gedit 3.6.1 it is included in the directory as install_ubuntu.sh

ricardograca commented 11 years ago

The problem is that my script works on Ubuntu 12.04, Gedit 3.4.1 so we can't have two scripts that do the same thing. Even better would be to modify the script to accept input options:

1) Install on current user's profile only 2) Install for all users

BTW, is gtksourceview-3-0 the preferred destination for Gedit themes? Also, could you check if you have the ~/.local/share/gedit directory?

HandyAndyShortStack commented 11 years ago

I do not have the ~/.local/share/gedit directory. Perhaps the best solution would be to check for the existence of ~/.local/share/gedit and /usr/share/gtksourceview-3.0, then install in whichever one(s) are present. I am not too good at bash scripts, but I'm sure I can have something working along those lines soon.

HandyAndyShortStack commented 11 years ago

Ok I just checked on another one of my computers running 12.04 and gedit 3.4.1. It has both directories, and I installed the additional themes in ~/.local/share/gedit/styles. Hmmmm. I will check if I can install new themes in 12.04/3.4.1 using /usr/share/gtksourceview-3.0/styles, and in 12.10/3.6.1 using ~/.local/share/gedit/styles. That could inform us as to how we will proceed.

I like the idea of giving the user install mode options.

I do not know what the gedit folks prefer for a user theme installation directory. It looks like the preinstalled themes are housed in gtksourceview-3.0 in both versions I have.

ricardograca commented 11 years ago

Then maybe that's what we should use as well. I suppose that anything that goes to the gtksourceview-3.0 directory will be available to any program that uses gtksourceview for code editing. We can probably put the themes in ~/local/share/gtksourceview-3.0 as well. I'll investigate this later today or tomorrow.

I just found the Solarized for Gedit repo and it has a very nice install script: https://github.com/mattcan/solarized-gedit

ricardograca commented 11 years ago

@HandyAndyShortStack Can you test the new script I just committed? It should work a lot better. You just use ./install.sh to install in your home directory or pass an additional -a option to install globally.

HandyAndyShortStack commented 11 years ago

Sorry its taken me so long to get back to you. I uninstalled some themes on my 12.10/3.6.1 machine, cloned your repository, and ran the install script. This is what I got:

install: 37: install: Syntax error: "}" unexpected

Themes were not reinstalled. I got the error with and without using the -a flag both as a user and as root. I will investigate the script now.

HandyAndyShortStack commented 11 years ago

OOPS! I was using sh to run the script. I used bash and it worked great! I can confirm that the install script works on 12.10/3.6.1 targetiong either the ~/.local/share/gtksourceview-3.0/styles directory or in the /usr/share/gtksourceview-3.0/styles directory (or both). Thanks for putting it together!

ricardograca commented 11 years ago

Great! I've included usage instructions on the readme that explain the command and how to use it, so hopefully no one tries to use it with sh install :) If there are more complaints about it I might drop the bash specific syntax.