search

ricardograca / gedit-themes

Color themes for Gnome's Gedit text editor
21 stars 7 forks source link

Mig repo merge #8

Closed typekpb closed 8 years ago

typekpb commented 8 years ago

there was some activity in the original (mig's) repo, since the fork => merged

ricardograca commented 8 years ago

Seems like the only actual change is in the zenburn theme, so if you could get rid of all the extraneous commits and just provide a new commit with that change it would be great :)

I'm also looking at other branches that have changes in regards to mig/gedit-themes and possibly also implementing those changes here.

typekpb commented 8 years ago

Well, might be true, but merging this one should lead to showing your repo as having no commits behind original one. (At least I hope so) as it might make people feel like your repo is not the actual one. On Dec 6, 2015 13:28, "Ricardo Graça" notifications@github.com wrote:

Seems like the only actual change is in the zenburn theme, so if you could get rid of all the extraneous commits and just provide a new commit with that change it would be great :)

I'm also looking at other branches that have changes in regards to mig/gedit-themes and possibly also implementing those changes here.

— Reply to this email directly or view it on GitHub https://github.com/ricardograca/gedit-themes/pull/8#issuecomment-162310220 .

ricardograca commented 8 years ago

Ok, makes sense, but there isn't actually an "actual one" ever since mig stopped updating his. There are several forks and I try to keep up with changes, but I don't have much time to go over every single fork out there.

That said, I think this fork still has the best install script out there ;)

ricardograca commented 8 years ago

After looking at the change, I'm not too sure about it. It just changes the selection color to orange instead of the current green, but if I merge this the theme file will contain two conflicting rules for selection color and the style of the new rules doesn't match the styles of the other ones, where the name attribute is always the last in each rule.

Also, the new orange selection color doesn't seem to be part of the usual Zenburn color palette, so I'd prefer to keep it as it is.

typekpb commented 8 years ago

Your repo, your rules :) Feel free to ignore this one. On Dec 6, 2015 13:53, "Ricardo Graça" notifications@github.com wrote:

After looking at the change, I'm not too sure about it. It just changes the selection color to orange instead of the current green, but if I merge this the theme file will contain two conflicting rules for selection color and the style of the new rules doesn't match the styles of the other ones, where the name attribute is always the last in each rule.

Also, the new orange selection color doesn't seem to be part of the usual Zenburn color palette, so I'd prefer to keep it as it is.

— Reply to this email directly or view it on GitHub https://github.com/ricardograca/gedit-themes/pull/8#issuecomment-162313496 .