search

riccardoscalco / crayon

Crayon.css is a list of css variables linking color names to hex values.
http://riccardoscalco.github.io/crayon/
MIT License
406 stars 25 forks source link

Modifications #2

Closed sillero closed 9 years ago

sillero commented 9 years ago

Hi there o/ nice project you got here :)

I forked and made some modifications, if you care to take a look. https://github.com/sillero/crayon

Basically:

fredericksilva commented 9 years ago

Nice Modifications View here

:+1:

riccardoscalco commented 9 years ago

Thanks man! I definitively have to learn gulp.

About the prefix, I understand the point, but I have a question: do you think is really necessary? On one side you have the benefit of preventing variable reassignments, but on the other side a prefix can result to be annoying. I decided to avoid a prefix because variables reassignment happens on a vertical order, therefore importing crayon at the very beginning of your stylesheet should not reassign variables. Moreover, css colors, like "seagreen" or "bisque", do not have a prefix and I found reasonable to do the same choice.

In situation like this I would prefer to take the laziest solution and see if people needs a prefix, I wonder of what are your thoughts.

sillero commented 9 years ago

I get your point about the prefix. We could leave the prefix property blank and let the user fill it as needed and recompile the stylesheets. How about that?

riccardoscalco commented 9 years ago

Good solution. I would like to merge your fork, can you send a pull request? Thanks.