search

riccoljy / pe

0 stars 0 forks source link

Presence of UniqueTagList in one diagram but not another #13

Open riccoljy opened 1 week ago

riccoljy commented 1 week ago

Seems to be inconsistencies for Model UML diagram

image.png

image.png

nus-pe-bot commented 4 days ago

Team's Response

We did not find the UniqueTagList component to be important enough to be included in the UML diagram, as the value to be added is insignificant, and would cause the diagram to be more cluttered. We included it in the first diagram as there was a mention about the usage of tags in our architecture, as seen in the screenshot below.

Screenshot 2024-11-17 at 11.15.16 PM (2).png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Upon reviewing the group's code, their AddressBook does not even include a UniqueTagList. Their project does have a seedu.address.model.person.UniquePersonList and a seedu.address.model.event.UniqueEventList, which makes the 2nd image accurate but the 1st inaccurate.

image.png

The only instance of UniqueTagList appearing is in the UML diagrams, and not in any actual implementation.

image.png