search

riccoljy / pe

0 stars 0 forks source link

Pseudo-duplicates allowed #4

Open riccoljy opened 1 week ago

riccoljy commented 1 week ago

UG does not acknowledge/give warning as per course website that these are different people despite being different just by an additional whitespace.

Course website states:

Similarly, extra white space (e.g., the user typed an extra space between the two names) is unlikely to mean they are two different persons. Typically, it is best if you can give a warning in such near match cases so that the user can make the final decision.

image.png

soc-pe-bot commented 4 days ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplication handling does not consider 'John doe' and 'John doe' as the same person due to additonal space in between

Screenshot 2024-11-15 at 4.32.20 PM.png

Adding an extra space in between john doe's name will not flag him as a duplicate. This is problematic as users can easily have typos and insert an additonal space in the name.

Can consider improving duplication handling by triming additonal spaces

[original: nus-cs2103-AY2425S1/pe-interim#816] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]