search

richarddwang / electra_pytorch

Pretrain and finetune ELECTRA with fastai and huggingface. (Results of the paper replicated !)
324 stars 41 forks source link

Assignment without usage. #18

Closed PhilipMay closed 3 years ago

PhilipMay commented 3 years ago

Hi,

here you assign something but do not use it later. Smells like a small bug.

https://github.com/richarddwang/electra_pytorch/blob/208c62fc3220b3ba318b5c9aed87d4ec75a3bea2/pretrain.py#L377

richarddwang commented 3 years ago

Thanks for the report Yes it is a bug. Although it doesn't affect default learning rate schedule that is the same as the official one uses, I have committed a change to pretrain.py.

Thanks you !