search

richardvenneman / trestle-mobility

🌐 Mobility integration plugin for the Trestle admin framework
MIT License
9 stars 5 forks source link

Ability to customise placeholder on the fields. #5

Closed asad-ali-bhatti closed 3 years ago

asad-ali-bhatti commented 3 years ago

This PR should add the ability for providing a placeholder as an option to the field.

Right now we are generating placeholder by combining label and selected locale read here.

In our project, we need to show a placeholder explaining to the user what he is supposed to write in this field. which is different than the label and much longer than that. I think it makes more sense to let users enter whatever they want as a placeholder to the field.

Along with this addition, I kept the existing functionality that if the user doesn't provide a placeholder we render field_name + selected locale.

richardvenneman commented 3 years ago

Great, thanks for your contribution!

richardvenneman commented 3 years ago

Just released trestle-mobility 1.4.0 with this change.

asad-ali-bhatti commented 3 years ago

@richardvenneman thank you.