richfitz / remake

Make-like declarative workflows in R
Other
340 stars 32 forks source link

Extract stop_if_duplicated() #143

Closed krlmlr closed 7 years ago

krlmlr commented 7 years ago

Uses anyDuplicated() instead of any(duplicated()) for performance, and includes the offending values in the error message. This might need tests, I'm also not sure how to best formulate the error message.

codecov-io commented 7 years ago

Current coverage is 89.27% (diff: 75.00%)

Merging #143 into master will increase coverage by 0.07%

@@             master       #143   diff @@
==========================================
  Files            26         26          
  Lines          2324       2321     -3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           2073       2072     -1   
+ Misses          251        249     -2   
  Partials          0          0          

Powered by Codecov. Last update 73c38c3...654101c

richfitz commented 7 years ago

Looks good thanks :)