Setting mode="wb" as default in download_file

richfitz / remake

Make-like declarative workflows in R

Other

340 stars 32 forks source link

Setting mode="wb" as default in download_file #65

Closed RemkoDuursma closed 8 years ago

RemkoDuursma commented 9 years ago

downloader::download does not work for binary files on Windows unless mode="wb" is set (and still works on Mac).

richfitz commented 9 years ago

Thanks Remko. The test failures here look unrelated to your change, but I'll hold off merging this until I have time to diagnose what has changed (probably an upstream package) and get that fixed.

I'm probably going to replace the downloader bits with some new code now that libcurl support is standard (ish) in R. And starting in a couple of weeks I'll have a windows machine for testing so expect better windows support soon.

krlmlr commented 8 years ago

Does it work better in the current development branch? remake is not using the downloader package anymore.

RemkoDuursma commented 8 years ago

I tried downloading an xls file with the latest version, and it works fine. Thanks.