search

rickyphewitt / emby-skill

This skill allows audio playback from an emby server
11 stars 19 forks source link

Allow non-MP3 source files to get transcoded #30

Closed benklop closed 5 years ago

benklop commented 5 years ago

don't use static=true, because if the media library contains non-mp3 types, they won't get transcoded. They still get the .mp3 extension, however, so vlc (or any other backend) really doesn't know what to do with them.

This PR also fixes an issue where results that are not artists, albums, or songs causes the emby plugin to crash.

rickyphewitt commented 5 years ago

My preference would be to squash merge the commits prior to a pull request but that is not a requirement. I didn't realize the static=true stopped transcoding. I had seen that via the emby web ui and just added it to the url. Because most of my library is mp3's I would never have come across the bug. Thank you for the updates!

rickyphewitt commented 5 years ago

Didn't realize I couldn't merge if I closed.

rickyphewitt commented 5 years ago

Also realize I can squash merge the pr :man_facepalming: