Since the generation of the signature file is done by directly writing the output of the apt backend command, it was easier to fix this when parsing the signature file by putting the line splitting in a try block and simple ignoring that line/item if that fails.
In my opinion this isn't even an issue that we should have to fix in apt-offline. It should be the case that apt and apt-get do not output this advertisement when you enable the highest quiet level like apt-offline does. If this is fixed in those tools later, this apt-offline fix will just have no effect but will not cause any problems. This fix should also protect against any future odd lines that they decide to have apt or apt-get print out even in quiet mode.
Fixes issue 199.
Since the generation of the signature file is done by directly writing the output of the apt backend command, it was easier to fix this when parsing the signature file by putting the line splitting in a
try
block and simple ignoring that line/item if that fails.In my opinion this isn't even an issue that we should have to fix in
apt-offline
. It should be the case thatapt
andapt-get
do not output this advertisement when you enable the highest quiet level likeapt-offline
does. If this is fixed in those tools later, thisapt-offline
fix will just have no effect but will not cause any problems. This fix should also protect against any future odd lines that they decide to haveapt
orapt-get
print out even in quiet mode.