The make_unsigned trait used by the AVR tests doesn't appear to do the right thing. I think there are some typos. As implemented, it seems to behave as you'd expect from a make_signed trait. Specifically, signed integral types are left unchanged by the trait, and for the unsigned types where there are specialisations, the trait actually adds signedness.
@adbancroft
The
make_unsignedtrait used by the AVR tests doesn't appear to do the right thing. I think there are some typos. As implemented, it seems to behave as you'd expect from amake_signedtrait. Specifically, signed integral types are left unchanged by the trait, and for the unsigned types where there are specialisations, the trait actually adds signedness.This PR ought to fix the issue, I think.