rifanece / timthumb

Automatically exported from code.google.com/p/timthumb
0 stars 0 forks source link

Image Aspect Ratios Not Maintained #2

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Image aspect ratios not maintained, images resized to w x h, instead of
keeping the original aspect ration and making sure it fits within w x h
bounds.  Images get stretched or compressed to fit.

Distorted:
http://mtb.redesigned.com/timthumb.php?src=/itemimages/CBdiaperareawash.jpg&w=14
0&h=180
Original:
http://mtb.redesigned.com/itemimages/CBdiaperareawash.jpg

Distorted:
http://mtb.redesigned.com/timthumb.php?src=/itemimages/item_20050426115915.jpg&w
=140&h=180
Original:
http://mtb.redesigned.com/itemimages/item_20050426115915.jpg

Original issue reported on code.google.com by jjar...@gmail.com on 14 Apr 2008 at 7:52

GoogleCodeExporter commented 8 years ago
Yes - agreed. While the script aims to make things more production oriented, 
it'd be far more useful if it used a 
MAX width or height without distortion of the other property.

Any suggestions? 

Original comment by kelter...@gmail.com on 12 Aug 2008 at 5:26

GoogleCodeExporter commented 8 years ago
Hmm - I've tried something like this:

$values = get_post_custom_values("Image"); echo $values[0]; 
?>&w=465&h="100%"&zc=0" 

Which keeps a constant defined width and the height follows to the correct 
aspect ratio, however when the 
script does it's work inside of WordPress (using the MImbo theme) it's not 
xHTML valid because of the quote 
marks around the 100%. Is there a way to do this and still generate clean xHTML?

Original comment by kelter...@gmail.com on 12 Aug 2008 at 6:25

GoogleCodeExporter commented 8 years ago
this was fixed a long time ago. I hadn't realised the issues section here was 
being
used :)

Setting the width/ height to 100% won't work. Tim Thumb was not programmed to
understand percentages.

The original problem was because the code was stretching the image. There is 
now a
parameter, zc, which will zoom and crop the image instead of just scaling it to 
the
new size.

Original comment by BinaryMoon on 4 Sep 2008 at 11:10