search

riferrei / srclient

Golang Client for Schema Registry
Apache License 2.0
236 stars 70 forks source link

Allow arbitrary subject names #4

Closed Navgeet closed 3 years ago

Navgeet commented 4 years ago

It would be nice if the library allowed using arbitrary subject names instead of appending -key or -value.

mntlty commented 3 years ago

This is the biggest blocker for me to use this library, as our team already has a convention on subject names that does not include these values. What is the context for this convention on subject names?

AtakanColak commented 3 years ago

It's related to Confluent Platform afaik. I want to solve this issue but can't really think of a way to allow it without breaking changes.

matrixise commented 3 years ago

Arghhh, I wanted to use this lib, but it's a blocking issue.

AtakanColak commented 3 years ago

All right, I'll work on it.

arkiaconsulting commented 3 years ago

@riferrei @AtakanColak Hi. I would like to contribute. I have a local branch ready to create schemas with arbitrary names.

AtakanColak commented 3 years ago

@arkiaconsulting Hi, thanks for your consideration. Could you create a pull request so we can work from there?

arkiaconsulting commented 3 years ago

@AtakanColak I don't have the permission to push a branch

AtakanColak commented 3 years ago

@arkiaconsulting You need to fork the project to a repo on your own, push your changes to it and then create pull request at your own repository. See https://opensource.com/article/19/7/create-pull-request-github

arkiaconsulting commented 3 years ago

@AtakanColak PR on the way

arkiaconsulting commented 3 years ago

@riferrei @AtakanColak Any chance to have a release from this commit ?

AtakanColak commented 3 years ago

@arkiaconsulting you are right, I created the release so versioning can be used as part of the modules

matrixise commented 3 years ago

Nice