riferrei / srclient

Golang Client for Schema Registry
Apache License 2.0
236 stars 70 forks source link

Implement ChangeSubjectCompatibilityLevel, GetGlobalCompatibilityLevel and GetCompatibilityLevel #53

Closed doxsch closed 3 years ago

doxsch commented 3 years ago

I have implemented the following two endpoints to be able to read the compatibility levels.

AtakanColak commented 3 years ago

First of all thank you for your PR. I'm just hesitant to add this functionality unless it is ever needed or requested.

doxsch commented 3 years ago

First of all thank you for your PR. I'm just hesitant to add this functionality unless it is ever needed or requested.

I understand your concerns, of course.

We need this functionality in a project. We will fill the schema registry in a Gitops approach. Therefore I reimplemented the more administrative endpoints, which it didn't need before. As far as I could find, this project is the only go client lib for the schema registry of confluent, so I implemented the parts relevant for us.

AtakanColak commented 3 years ago

All right. Approving this one, but you'll need to modify #54 so it doesn't break compatibility.