search

riferrei / srclient

Golang Client for Schema Registry
Apache License 2.0
236 stars 70 forks source link

add producer protobuf example #85

Closed bigkraig closed 1 year ago

bigkraig commented 2 years ago

run tilt up once you have tilt installed. I didn't have time this morning to show a consumer but it is close to the producer.

AtakanColak commented 2 years ago

Hi,

I've just finished my work on #86 which uses Docker and Docker Compose for integration testing and adds GitHub Action for it.

Would you be willing to use that structure rather than tilt?

Either ways, thank you for the PR, I'm not sure when I'll find the time to review it so perhaps @riferrei could help out.

riferrei commented 2 years ago

I think this PR brings enormous value to this repo, as many people are shifting from Avro to Protobuf these days. Myself included. 😅

However, I would rather avoid introducing new technologies to this repo. Docker/Docker Compose are more common options for integration testing, so maybe adapt this PR to use the changes brought by @AtakanColak with https://github.com/riferrei/srclient/pull/86?

Tilt is great, BTW. I just want to minimize the friction of people onboarding with this library.

AtakanColak commented 2 years ago

Hi @bigkraig, are there any updates on this? This contribution is very valuable 💎

bigkraig commented 2 years ago

Hey sorry everybody, I've since noticed that Confluent very recently added a go client for the schema registry and have moved over to that.

AtakanColak commented 1 year ago

Hi, I'm closing this PR due to timeout, but am adding it to TODO list.