search

ringcentral / ringcentral-php

RingCentral Connect Platform PHP SDK
MIT License
54 stars 52 forks source link

Add laravel 8 support with Guzzle 7 and fix tests for all php versions #92

Closed coxlr closed 4 years ago

coxlr commented 4 years ago

Add support for Laravel 8 with Guzzle 7.

Also fixed tests for all PHP versions and added GitHub workflow to run tests on push and pull requests.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.3%) to 86.392% when pulling 264cdb8ee7c6724750caaddff1b00995bdd15c12 on coxlr:laravel-8 into fe749195898b94c3ae48296edeecdfc31b4b3eb1 on ringcentral:master.

coxlr commented 4 years ago

Is it possible to get this merged?

kirill-konshin commented 4 years ago

No need for Github action, Travis does it's job just fine. Please remove it and I will merge & release.

kirill-konshin commented 4 years ago

Also what was the point to replace annotations?

kirill-konshin commented 4 years ago

Also tests failed in Travis.

coxlr commented 4 years ago

Great thanks. I have removed the GitHub actions. The tests are also failing in travis in the current version. I have fixed the actual tests for the used php version and tested using the GitHub actions that I initially added were they all pass.

I believe the current failing in travis is due to the PHP version that runs on travis-ci was compiled with gnutls-cli (GnuTLS) 2.12.23, from 2011. This specific version of gnutls-cli has problems with some (but not all) TLS 1.2 connections. See: https://stackoverflow.com/questions/38375211/curl-error-35-gnutls-handshake-failed

The @ExpectedException, @expectedExceptionCode, @expectedExceptionMessage, and @expectedExceptionMessageRegExp annotations are deprecated and removed in PHPUnit 9.

coxlr commented 4 years ago

I have fixed the travis tests, it looks like the issue with PHP 7.1 is something they are aware of, there is an open issue for it: https://github.com/travis-ci/travis-ci/issues/6339 Setting the PHP version to 7.1.18 allows the tests to successfully run and pass for PHP 7.1. I also added PHP 7.4 to the matrix.

coxlr commented 4 years ago

Is there anything else I can do, or help with to get this merged?

kirill-konshin commented 4 years ago

Merged & published. Thank you.