search

rinukkusu / spotify-dart

A dart library for interfacing with the Spotify API.
BSD 3-Clause "New" or "Revised" License
207 stars 93 forks source link

_$AlbumFromJson is not working when there is releaseDate #84

Closed stefanoromanello closed 3 years ago

stefanoromanello commented 4 years ago

I see that the Album class is extending AlbumSimple and is overriding releaseDate and releaseDatePrecision without assigning the value to the superclass. The result of _$AlbumFromJson is so an Album with releaseDate and releaseDatePrecision equals null. I suggest removing the override from the Album class.

hayribakici commented 3 years ago

@stefanoromanello I agree. The releaseDate and releaseDatePrecision are not necessary in Album as AlbumSimple already have them. I created a PR #99 for that. @rinukkusu What do you think?