riobard / go-shadowsocks2

Experimental Shadowsocks in Go. Stable fork at https://github.com/shadowsocks/go-shadowsocks2
Apache License 2.0
719 stars 1.67k forks source link

Fix AEAD stream writer to write a big chunk buffer #29

Closed Dreamacro closed 6 years ago

Dreamacro commented 6 years ago

Problem

I used riobard/go-shadowsocks2 as an ss-client in my project and I wrapper a net.Conn after StreamConn without WriteTo and ReadFrom.

Then I use io.Copy with two TCP connection. In AEAD cipher, I found out that the connection closes when to upload some images. The Writer is not written correctly when writing a big buffer.

Question

When I discovered this bug, I assumed that shadowsocks/go-shadowsocks2 had the same bug. But when I went to check, I found a big gap between the two implementations. So the two repositories are completely forked?