search

riolubruh / YABDP4Nitro

Yet Another BetterDiscord Plugin for Nitro features. Unlock screensharing modes, use cross-server and gif emotes and much more!
Other
803 stars 140 forks source link

userbg integration works but the banner is not updated #220

Closed speedlorenzo12 closed 5 months ago

speedlorenzo12 commented 5 months ago

I had a semi-corruption of the banner due to the change in the source in which the banners are stored, I updated it 2 times but it remained the same as the first time, could you give me a possible solution or you do a possible correction? (from og plugin works correctly) (and I saw that experiments no longer appear)

riolubruh commented 5 months ago

What does this even mean

speedlorenzo12 commented 5 months ago

old banner (YABD4NITRO) (black banner for a second) Screenshot 2024-06-29 075618 new banner (other clients and og usrbg the latest and correct banner) Screenshot_2024-06-29-07-57-08-865_

riolubruh commented 5 months ago

Looks like the Vencord UsrBG plugin has some CSS that expands the banner area. I have added it now, so it will be in the next release. (It being black for a split second is likely just it taking a second to load, since I did not program it to wait for it to finish loading the banner.)

speedlorenzo12 commented 4 months ago

I found the origin of the strange bug, for some reason the id selector gets the wrong image and takes the old one, it's a bug in the plugin itself not other plugins (I put the right id in place of the id selector)

riolubruh commented 4 months ago

I don't understand; you say it's the wrong image, but the screenshots you sent literally have the same image in both, just cropped differently..? All the plugin does is check if a user is registered in the UsrBG database and, if they are, returns the banner URL as https://usrbg.is-hardly.online/usrbg/v2/${user.userId}?size=4096, which, as far as I can tell, is identical to the Vencord implementation...? Edit: Okay maybe there is one difference. The Vencord implementation includes an "etag" as a URL parameter, which are specified in https://usrbg.is-hardly.online/users in the format userid: etag. Is this what could be causing the issue?

speedlorenzo12 commented 4 months ago

they are not the same, maybe I explained it wrong. the edges are not cut well and you can see a light color that has nothing to do with it and at the end of the gif everything is shown black, so I had to make a second request for fix this problem but this plugin uses the wrong gif. however it could solve the problem