search

riot / custom-elements

Simple API to create vanilla custom elements with riot
MIT License
35 stars 3 forks source link

Separated class build from define #3

Closed georges-gomes closed 5 years ago

georges-gomes commented 5 years ago

Hi! https://webcomponents.dev works better with the class than direct define. With this we can release a support for Riotjs 👍 Thanks

cekvenich commented 5 years ago

Cool thing about standard custom elements is that they work on ie11. Would this facilitate IE11 support?

georges-gomes commented 5 years ago

@cekvenich I don't think it make any difference because the polyfill is probably at the customElement.define() level.

cekvenich commented 5 years ago

Yes, I can pre-load anything needed before it gets to that. I look forward to a regular example. I hope there are no imports. I will then try to make that example ie11.

GianlucaGuarini commented 5 years ago

@cekvenich please make sure the tests pass

georges-gomes commented 5 years ago

My fault, I'm sorry

GianlucaGuarini commented 5 years ago

thank you

GianlucaGuarini commented 5 years ago

this feature was added in v4.1.0

georges-gomes commented 5 years ago

👍It's working! We will release soon

GianlucaGuarini commented 5 years ago

@georges-gomes thank you for taking the time for it