search

ripple / ripple-client

A UI for the Ripple payment network built using web technologies
ISC License
1.34k stars 494 forks source link

No notification when an order fills #153

Closed jedmccaleb closed 11 years ago

jedmccaleb commented 11 years ago

They need something telling them an order happened

justmoon commented 11 years ago

We need to be able to show transactions and a list of their relevant side-effects.

For example, here is a simple payment:

Bob sent you 200 USD

But this transaction could have side effects:

Bob sent you 200 USD -> You sold 200 USD for 2400 XRP.

There could also be transactions where we only care about the side effects. In that case we wouldn't show the transaction itself at all:

(Alice sent Box 70 USD) -> You sold 50 USD for 600 XRP -> You sold 20 USD for 300 XRP. This order has 120 USD remaining

In other words, the notification history will show transactions consisting of zero or one transaction descriptions and zero or more side effect descriptions.

nanocoin commented 11 years ago

Newbie here, so apologies if this is not the right place to ask this question, but are orders "transactions"? Or is a resulting trade that occurs from that order a "transaction." It is confusing to see the history of orders but not the related transactions. Thanks.

jtimon commented 11 years ago

Orders are transactions that get into the ledger too (any devs that know the server better can correct me if I'm wrong). Here, on the wiki: https://ripple.com/wiki/Transactions#OfferCreate_.287.29

justmoon commented 11 years ago

Implementation is incorrect. Order filling is a transaction side effect, not a type of transaction. (See my explanation above.) You can have a payment that also fills an order. You can have a transaction that fills two or three or ten offers.

Reopening. Please talk to me if there are any questions.

vhpoet commented 11 years ago

Yea, I know, that's not completed yet