ripple / rippled-historical-database

SQL database as a canonical source of historical data
97 stars 68 forks source link

Get Single Validator Report is showing unexpected data #199

Closed AJ58O closed 5 years ago

AJ58O commented 5 years ago

I have an app that is pulling single validator reports from this API. I have some concerns about the accuracy and reliability of the 24 hour agreement scores. In some instances I'm seeing scores from the API are significantly lower than what I see on xrpcharts.ripple.com/#validators and other explorers like bithomp. This seems to consistently be an issue with nHUT5yg3QwqwaVN3qcCJ46vSSTNXR1zfXUapp7xzB2gw6tMuJwq2 which currently has a 24hr agreement score of 1.000 on xrpcharts and on bithomp, but shows a score of .9994 from the API for today:

{'result': 'success', 'count': 2, 'reports': [{'validation_public_key': 'nHUT5yg3QwqwaVN3qcCJ46vSSTNXR1zfXUapp7xzB2gw6tMuJwq2', 'date': '2019-07-20T00:00:00Z', 'chain': 'main', 'score': '1.0000', 'total': '2397', 'missed': '0', 'incomplete': True}, {'validation_public_key': 'nHUT5yg3QwqwaVN3qcCJ46vSSTNXR1zfXUapp7xzB2gw6tMuJwq2', 'date': '2019-07-21T00:00:00Z', 'chain': 'main', 'score': '0.9994', 'total': '18023', 'missed': '10'}]}

This is one of the closer instances of parity, but I've seen some that are significantly less close-- agreement scores of ~.5 coming from the API whereas bithomp and xrpcharts show 1.000. Can the agreement scores from this API be consistently relied upon? I am sending real funds over the ILP based on these scores so I'd like to make sure they are accurate.