riscv-collab / riscv-gnu-toolchain

GNU toolchain for RISC-V, including GCC
Other
3.56k stars 1.17k forks source link

Enable Linux/uClibc-ng toolchain build in CI #1578

Closed TommyMurphyTM1234 closed 1 month ago

TommyMurphyTM1234 commented 1 month ago

See:

Notes:

  1. I don't think that I can test these changes locally so am creating the PR on the assumption that they will be sanity checked server side.
  2. While "ulibc" is used across riscv-gnu-toolchain to refer to this toolchain variant, it is actually uClibc-ng based and not based on the original uClibc.
  3. For this reason I have used "uclibc-ng" when naming the build tarball artifact but I don't know if the dash in this string will be in any way problematic or inconsistent with the existing naming convention?
  4. I may need to rebase this if/when other pending PRs that I have submitted today are merged.
  5. I am assuming that, like the Linux/musl toolchain variant. LLVM is also not an option for the uClibc-ng toolchain?
  6. As ever, I'm open to constructive feedback and comments. :-)
TommyMurphyTM1234 commented 1 month ago

Second attempt at doing this:

cmuellner commented 1 month ago

It looks good now ("This branch has no conflicts with the base branch when rebasing"). I'll merge once the CI build is done.

TommyMurphyTM1234 commented 1 month ago

It looks good now ("This branch has no conflicts with the base branch when rebasing"). I'll merge once the CI build is done.

Thanks @cmuellner. 👍

TommyMurphyTM1234 commented 1 month ago

Oops - mistake in original commit addressed here:

TommyMurphyTM1234 commented 1 month ago

Thanks a lot @cmuellner. 👍