Add requirement `python3-tomli` - Githubissues

riscv-collab / riscv-gnu-toolchain

GNU toolchain for RISC-V, including GCC

Other

3.56k stars 1.17k forks source link

Add requirement `python3-tomli` #1614

Open karaketir16 opened 1 week ago

karaketir16 commented 1 week ago

python3-tomli required for build-sim SIM=qemu in Ubuntu 22.04, I did not try other operating systems.

karaketir16 commented 1 week ago

fix #1615

TommyMurphyTM1234 commented 1 week ago

python3-tomli required for build-sim SIM=qemu in Ubuntu 22.04, I did not try other operating systems.

Why wouldn't this have triggered a problem here?

https://github.com/riscv-collab/riscv-gnu-toolchain/blob/444c01e1ac7c2e3dbab22441bfff21d50edf2712/.github/workflows/nightly-release.yaml#L87-L90

when this package isn't part of the prerequisites installation script?

https://github.com/riscv-collab/riscv-gnu-toolchain/blob/444c01e1ac7c2e3dbab22441bfff21d50edf2712/.github/setup-apt.sh#L6-L9

karaketir16 commented 1 week ago

If I understand correctly, you are using a GitHub Ubuntu Image, that has pre-installed tools.

https://github.com/actions/runner-images/blob/ubuntu22/20241015.1/images/ubuntu/Ubuntu2204-Readme.md

But, I cannot found tomli in the list.

karaketir16 commented 1 week ago

The error is added with this patch.

https://patchwork.kernel.org/project/qemu-devel/patch/20230828103856.46031-6-pbonzini@redhat.com/

karaketir16 commented 1 week ago

I have checked.

https://github.com/karaketir16/test-workflows/actions/runs/11853849709/job/33034785384#step:4:1

GitHub Runner Ubuntu 22.04 image has tomli

mickflemm commented 4 days ago

I ran this a few days back on a fresh ubuntu 22.04 container from the LXD repo and I didn't have to install tomli, the build script of QEMU uses a python venv and installs needed packages itself.