search

riscv / riscv-fast-interrupt

Proposal for a RISC-V Core-Local Interrupt Controller (CLIC)
https://jira.riscv.org/browse/RVG-63
Creative Commons Attribution 4.0 International
238 stars 49 forks source link

Move register layout definitions into wavedrom #414

Open christian-herber-nxp opened 1 week ago

christian-herber-nxp commented 1 week ago

The privileged spec defines the CSR layouts using wavedrom. The CLIC spec doesn't. This should be aligned. The layout diagrams do not include descriptions, while the CLIC tables do.

Proposed Resolution: Move CLIC CSR layouts to wavedrom. Merge the description text with from the layout table with the rest. There might be redundancies, in which the text that doesn't come from the table should take presedence.

wmat commented 4 days ago

Can you point me at a CSR diagram from the Privileged spec that you would expect the CSRs here to look like?

wmat commented 4 days ago

Maybe mnstatus from the rnmi chapter 8.3?

christian-herber-nxp commented 4 days ago

I think we are open to whatever is the preferred presentation by the documentation team. I was looking at the privileged spec itself, i.e. definition of machine mode.