search

riscv / sail-riscv

Sail RISC-V model
https://lists.riscv.org/g/tech-golden-model
Other
467 stars 169 forks source link

Fix all Sail compilation warnings #540

Closed Timmmm closed 2 months ago

Timmmm commented 2 months ago

Add pure/impure annotations and remove some duplicate function declarations.

Timmmm commented 2 months ago

@Alasdair I wasn't sure if printing functions should count as pure or impure from Sail's perspective seeing as they're technically impure but the Sail model can't actually observe the impurity.

github-actions[bot] commented 2 months ago

Test Results

712 tests  ±0   712 :white_check_mark: ±0   0s :stopwatch: ±0s   6 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit ae1e75e8. ± Comparison against base commit a58c58c6.

:recycle: This comment has been updated with latest results.

Timmmm commented 2 months ago

@billmcspadden-riscv also this one can be merged.

Timmmm commented 2 months ago

Btw I would recommend using squash and merge, especially when there's only one commit in the PR. Otherwise you get a needlessly convoluted commit history.