search

riscv / sail-riscv

Sail RISC-V model
https://lists.riscv.org/g/tech-golden-model
Other
467 stars 169 forks source link

Remove N extension #584

Closed Timmmm closed 1 month ago

Timmmm commented 1 month ago

This extension was never ratified, has been removed from the ISA manual and apparently would need significant changes if it were to ever come back.

Therefore it makes sense to remove it from the model in order to simplify the code.

This was written by @KotorinMinami in #531, I then made some minor formatting changes and some refactoring of the interrupt handling in this commit, and finally rebased it.

github-actions[bot] commented 1 month ago

Test Results

396 tests  ±0   396 :white_check_mark: ±0   0s :stopwatch: ±0s   4 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit eac9139a. ± Comparison against base commit 2b65a0d3.

:recycle: This comment has been updated with latest results.

Timmmm commented 1 month ago

Yeah it's making writing CLIC a pain too, e.g. it's difficult to make a function get_xcause(p : Privilege) -> xlenbits due to the compilation order and I thought about making it a scattered function but I decided getting this merged would be better.

KotorinMinami commented 1 month ago

@Timmmm There's absolutely nothing wrong with anything you've done. On the contrary, I'm quite pleased and grateful that you've managed to help resolve the conflicts when merge into master. Similarly, I do hope this PR can be merged and make a valuable contribution to our gold model.

Timmmm commented 1 month ago

@billmcspadden-riscv any objection to merging this?

Timmmm commented 1 month ago

I think we've got good agreement on this anyway and it will make Alasdair and Jordan's lives easier so I'll merge it on Thursday if nobody objects before then.

billmcspadden-riscv commented 1 month ago

Looks like there are some conflicts that must be resolved.

Bill Mc.

On Tue, Oct 15, 2024 at 3:26 AM Tim Hutt @.***> wrote:

I think we've got good agreement on this anyway and it will make Alasdair and Jordan's lives easier so I'll merge it on Thursday if nobody objects before then.

— Reply to this email directly, view it on GitHub https://github.com/riscv/sail-riscv/pull/584#issuecomment-2413221032, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXROLOCOGHXRF2XNQKHM2QDZ3TGRZAVCNFSM6AAAAABPUSASEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTGIZDCMBTGI . You are receiving this because you were mentioned.Message ID: @.***>

-- Bill McSpadden Formal Verification Engineer RISC-V International mobile: 503-807-9309

Join me at RISC-V Summit North America http://www.riscvsummit.com/ in October!