search

risingwavelabs / risingwave

Best-in-class stream processing, analytics, and management. Perform continuous analytics, or build event-driven applications, real-time ETL pipelines, and feature stores in minutes. Unified streaming and batch. PostgreSQL compatible.
https://www.risingwave.com/slack
Apache License 2.0
6.73k stars 554 forks source link

perf: generate differential flamegraph #13476

Open BugenZhao opened 9 months ago

BugenZhao commented 9 months ago

We have continuous integration on the performance benchmark. When a regression occurs, we can download flame-graphs to investigate the problem. However, it's not intuitive to compare two flamegraphs and often leads to confusing results. For example, in #12959 we even reversed the results before and after the regression! 😅

It will be better if we can automate to find the diff of two flamegraphs. Some references that might be helpful:

xxchan commented 9 months ago

I think there may be a low-hanging fruit: just provide the stackcollapsed file together with the svg. Then we can manually diff them.

github-actions[bot] commented 6 months ago

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

BugenZhao commented 6 months ago

Another use case is for the memory flame graph to track how allocation grows over time.

github-actions[bot] commented 2 months ago

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.