search

riteshgandhi / ng-star-rating

Highly Customizable and Responsive Star Rating library built using Angular
MIT License
38 stars 10 forks source link

Shadow Root #35

Open marwilc opened 4 years ago

marwilc commented 4 years ago

Describe the bug we currently have this package installed in our angular project, and we have seen glitches in the rendering, where the component is included. seeing with the inspector we have detailed that all our styles are included within Shadow Root in that component. That makes it take a long time to load when displaying the corresponding page.

To Reproduce Steps to reproduce the behavior:

  1. 'have a large project with multiple styles in the style.scss'
  2. .include stars-rating multiple times as a grid'
  3. 'check shadow root in inspector'
  4. See error

Expected behavior It is necessary that it does not have any delay in the load of the view, and more if you work with a grid of n items that include the start-rating

Screenshots If applicable, add screenshots to help explain your problem. image (5) Annotation 2020-09-10 132245 Annotation 2020-09-10 132245

Desktop (please complete the following information):

Additional context none

riteshgandhi commented 4 years ago

I'll have a look at the issue and get back to you. Thanks for using the package.

On Thu, Sep 10, 2020, 1:44 PM Marwil Campos notifications@github.com wrote:

Describe the bug we currently have this package installed in our angular project, and we have seen glitches in the rendering, where the component is included. seeing with the inspector we have detailed that all our styles are included within Shadow Root in that component. That makes it take a long time to load when displaying the corresponding page.

To Reproduce Steps to reproduce the behavior:

  1. 'have a large project with multiple styles in the style.scss'
  2. .include stars-rating multiple times as a grid'
  3. 'check shadow root in inspector'
  4. See error

Expected behavior It is necessary that it does not have any delay in the load of the view, and more if you work with a grid of n items that include the start-rating

Screenshots If applicable, add screenshots to help explain your problem. [image: image (5)] https://user-images.githubusercontent.com/20113479/92770936-70a17800-f368-11ea-8627-603c508e023b.png [image: Annotation 2020-09-10 132245] https://user-images.githubusercontent.com/20113479/92771287-beb67b80-f368-11ea-8044-bb43f7bbc4b6.png [image: Annotation 2020-09-10 132245] https://user-images.githubusercontent.com/20113479/92771387-d857c300-f368-11ea-8c2f-47f3e9ada3f2.png

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 88

Additional context none

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/riteshgandhi/ng-star-rating/issues/35, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7LJQWA2CZJQII4F3TCJM3SFEDULANCNFSM4RFPO3WA .