search

riverrun / argon2_elixir

Elixir wrapper for the Argon2 password hashing algorithm
Apache License 2.0
229 stars 34 forks source link

Make Comeonin optional #46

Closed kdawgwilk closed 3 years ago

kdawgwilk commented 3 years ago

I am using this library for creating a blind index column in the database and don't need the Comeonin dep so it would be nice to mark that as optional.

riverrun commented 3 years ago

Hi. First of all, sorry about the delay in getting back to you - really busy here.

About the PR, I cannot merge it as it will break things for many other developers.

About making Comeonin optional, or just not having it as a dependency and moving the needed code to argon2_elixir, feel free to open an issue at https://github.com/riverrun/comeonin. I am open to the idea, but it all depends on what feedback I get from other developers.