search

riverrun / argon2_elixir

Elixir wrapper for the Argon2 password hashing algorithm
Apache License 2.0
229 stars 34 forks source link

chore(Elixir): Fix charlist warning in elixir 1.17 #62

Closed tomciopp closed 1 month ago

tomciopp commented 5 months ago

@riverrun Elixir emits a warning for charlists not declared using the ~c"" sigil in version 1.17.0. Looking up the docs for erlang's filename module it looks like strings are the preferred method for joining paths.

https://www.erlang.org/doc/apps/stdlib/filename.html#join/1

anthonator commented 1 month ago

@riverrun any chance to get this merged and released?

riverrun commented 1 month ago

Sorry for the delay in getting round to this. I have just updated this myself, as there were a few other changes that needed to be made. This change is now part of v4.1.0.

And many thanks for your help.

riverrun commented 1 month ago

@tomciopp regarding your reference to using strings instead, and the Erlang documentation, Erlang strings are equivalent to Elixir charlists, and so I have use ~c sigil to update this.

anthonator commented 1 month ago

Awesome! Thank you!